Feat: (WIP) Stdlib functions #102
Open
+463
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to accept any TypedColumn
# Conflicts: # kotlin-spark-api/3.0/src/main/kotlin/org/jetbrains/kotlinx/spark/api/ApiV1.kt # kotlin-spark-api/3.0/src/test/kotlin/org/jetbrains/kotlinx/spark/api/ApiTest.kt
|
@Jolanrensen would you be able to fix the conflicts? |
|
@asm0dey It's nowhere near finished though. |
|
IMHO it is, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the issue #100 it would be nice to have more stdlib functions to work with Datasets too, since it's one of Kotlin's selling points.
I've started converting the _Collections.kt from the stdlib to Dataset and I've managed to get to about a third, to
filterIndexed.It already contains a lot of helpful functions, like
last(),firstOrNull {},drop(),all {}etc, but there are many left to do.Many are faster but prone to out of memory issues when first converted to an Iterable. This holds for functions like
first {}etc. I plan to have a code inspection plugin hint the user in these cases.It's nowhere near done, but since I'm going away for a couple of weeks, I thought it might be cool to share the functions I already created so they can be tested already and maybe encompassed in the API itself. Of course, feel free to continue my work in my absence. Many stdlib functions are still left and the RDD could also use them ;).